New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch to make "fight formation" fail gracefully on non-existant formation #81

Closed

ohrrpgce-bugbot opened this issue Jun 12, 2005 · 4 comments

Labels

bug rel: rusalka scripts

ohrrpgce-bugbot commented Jun 12, 2005

[bz#81]

If you specify the formation that doesn't exists, the game still goes into the
battle mode, and then quits it like you have won the battle.
what this patch does is that it makes sure that the formation is in the
reasonable range, if not, it returns -1

From: Yuriy Melnichenko <yuriym19>
Reported version: 20051003 Rusalka

Author

ohrrpgce-bugbot commented Jun 12, 2005

Comment author: Yuriy Melnichenko <yuriym19>

Created attachment 35
the patch for fight formation command

here is the patch

Attached file: fightformation.txt (text/plain, 571 bytes)
Description: the patch for fight formation command

Author

ohrrpgce-bugbot commented Jun 13, 2005

Comment author: @pkmnfrk

Actually, bugs aren't marked closed until the patch has been applied. I'm
reopening it now, but I'll commit the patch, and all will be good.

Author

ohrrpgce-bugbot commented Jun 13, 2005

Comment author: @pkmnfrk

Ok, the patch has been committed. NOW it can be closed.

Author

ohrrpgce-bugbot commented Jun 13, 2005

Comment author: @bob-the-hamster

fixing summary

ohrrpgce-bugbot closed this as completed

ohrrpgce-bugbot added scripts bug rel: rusalka labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment