Comment author: Yuriy Melnichenko <yuriym19>

Created attachment 37
poison/stun indicator

Ok. this patch lets you select what sort of characters you want to use to
indicate that you have been poisoned or stunned.
it adds the 2 new menu items to the general game data(to the bottom of the
list)
you can either type in the number, scroll through the number, or pick the
character with charpicker(just like in textboxes and other stuff)

also modified the bmod to actually put the character after hp numbers
example:2992/9934PS,9999/9999P,9999,9999 S,0,0 PS
except that the indicator are pixel farther than the usual number.
tested and it works.
I would have put the indicators into the hero names, but if the heroname will
fill up, the indicators would run through the numbers.
for this gen(60) and gen(61) are used to store the indicators(ascii characters)

Attached file: poisomind.txt (text/plain, 2752 bytes)
Description: poison/stun indicator

Comment author: @pkmnfrk

Nice, three patches in two days! This are comitted, and I think it's time for
another WIP!

Comment author: @bob-the-hamster

Re-opening. I wanna change the entry of these in custom. You should actually
enter the char, as if entering a one-letter string, rather than entering the
ascii code.

Comment author: @rversteegen

It would be important to note that gen(60) is already used (for the joystick
calibration disabling). gen(61) and gen(62) would work (I think)

Comment author: Yuriy Melnichenko <yuriym19>

Created attachment 38
fixed the patch

ok, noted that gen(60) is indeed used for joystick, so I used 61 and 62
and about Jame's suggestion, I tried to do what you wanted, but it wouldn't
work right for me. so I didn't change that portion of the code.

Attached file: fixed83.txt (text/plain, 2570 bytes)
Description: fixed the patch

Comment author: @bob-the-hamster

Applied the 60->61, 61->62 fix.
I'll see what I can do about the entry in custom.
I was also thinking there should be defauls for games that have not defined this
(like, if the value is 0, it will use some reasonable default instead)

Comment author: Yuriy Melnichenko <yuriym19>

why not use 161, and 159? they seem to be the ones that are close to stun,and
poison indicators.

Comment author: Yuriy Melnichenko <yuriym19>

Created attachment 39
poison/stun indicator defaults

well here is the patch for the above comment.

Attached file: defaults.txt (text/plain, 624 bytes)
Description: poison/stun indicator defaults

Comment author: @bob-the-hamster

The defaults need to go in GAME, not in custom, so that they get set even on RPG
files that have not been loaded and edited with the latest CUSTOM

Comment author: Yuriy Melnichenko <yuriym19>

Created attachment 40
poison/indicators default in game

its nice to have it in custom as well, so I added it to bmod
so now its also in GAME

Attached file: default2.txt (text/plain, 834 bytes)
Description: poison/indicators default in game

Comment author: Yuriy Melnichenko <yuriym19>

Comment on attachment 40
poison/indicators default in game

don't like this one

Attached file: default2.txt (text/plain, 834 bytes)
Description: poison/indicators default in game

Comment author: Yuriy Melnichenko <yuriym19>

Created attachment 41
edited game/poison default

ok, I like this one a little better.

Attached file: default2.txt (text/plain, 662 bytes)
Description: edited game/poison default

Comment author: @bob-the-hamster

It would be better to do the defaults once at the beginning of battle, rather
than on every paint cycle. In fact, the same goes for the LTRIM$(CHR$())

Comment author: Yuriy Melnichenko <yuriym19>

Created attachment 42
indicator defaults moved

ok, I moved the default code to the beginning of battle. Also removed the
ltrims since its pointless in 1 character string.

Attached file: default3.txt (text/plain, 899 bytes)
Description: indicator defaults moved

Comment author: @bob-the-hamster

Groovy. Applied the patch. Thanks!

Comment author: @pkmnfrk

I just noticed a minor bug: When you go into the General Game Data on a game
that hasn't had the icons set, they'll show as 0 until you highlight the
options, at which point they'll mysteriously jump to 32.

Comment author: Yuriy Melnichenko <yuriym19>

apply patch 39, it sets the defaults in custom.

Comment author: Yuriy Melnichenko <yuriym19>

Created attachment 43
poison/stun defaults in custom

actually apply this patch to it, the last one wasn't so good.
and James was gonna redesign the menu anyway, but in the meantime, this will
work.

Attached file: def4.txt (text/plain, 455 bytes)
Description: poison/stun defaults in custom

Comment author: @pkmnfrk

Created an attachment (id=43) [edit]
poison/stun defaults in custom

actually apply this patch to it, the last one wasn't so good.
and James was gonna redesign the menu anyway, but in the meantime, this will
work.

Ok, I applied the patch, and comitted it. James didn't commit the other one
(39), so I'm committing this one.

Comment author: @pkmnfrk

Ok, this is done, AFAIK, so I'll re-close it.