Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash/hang on exit in Windows version after plotscript error #103

Closed
ohrrpgce-bugbot opened this issue Nov 13, 2005 · 6 comments
Closed
Labels
bug Yeah... that's broken crash Bugs causing a crash, freeze/hang, abort(), or FB fatal error os: windows Windows-specific rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16

Comments

@ohrrpgce-bugbot
Copy link

[bz#103]

When exiting the Windows version of GAME.EXE the program freezes, and has to be
killed with CTRL+ALT+DEL

As far as I know, this only happens on Windows 98, I think Windows XP is okay. I
need confirmation of this, and testing on other Windows versions.

From: @bob-the-hamster
Reported version: 20060215 Serendipity
Operating system: Windows 98

@ohrrpgce-bugbot
Copy link
Author

Comment author: @bob-the-hamster

Oops! I recant! My previous theory was incorrect. This has nothing to do with
Windows 98 vs Windows XP. This crash/hang only happens after a plotscripting
error (I had some broken plotscripts in Wander when I was testing)

It seems that after a plotscripting failure, exiting the Windows version of GAME
does not work.

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

I can't reproduce this, although I noticed something else: When I triggered a
script error (I popped a noop into a script), nothing showed up on screen
(although I still needed to press a key). I debugged it with gdb, and confirmed
that it does, in fact, enter scripterr, so...

I'm tempted to mark this 'worksforme' unless someone can re-confim it.

@ohrrpgce-bugbot
Copy link
Author

Comment author: @bob-the-hamster

I can't reproduce this, although I noticed something else: When I triggered a
script error (I popped a noop into a script), nothing showed up on screen
(although I still needed to press a key). I debugged it with gdb, and confirmed
that it does, in fact, enter scripterr, so...

I'm tempted to mark this 'worksforme' unless someone can re-confim it.

I think your right, but let's get one more person to verify it before WFMing it.

As for the error failing to show up, I am guessing maybe that has something to
do with the minor changes to screen page behaviour. I'll bet we need to add a
setvispage vpage right after drawing the error message

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

Yes, you're right. Oddly enough, the error gets drawn to two pages, 0 and 1.
Dunno why, but regardless, I comitted a patch (and tested it), so it shows up again.

@ohrrpgce-bugbot
Copy link
Author

Comment author: @bob-the-hamster

Yes, you're right. Oddly enough, the error gets drawn to two pages, 0 and 1.
Dunno why, but regardless, I comitted a patch (and tested it), so it shows up
again.

Cool. Good work.

The double drawing of the error message was so that the message would be seen
without a setvispage. I have no idea why I went out of my way to avoid using
setvispage there. I suspect I must have originally written that code under
sleep-deprivation (or oxygen depravation)

Fixed and commited.

@ohrrpgce-bugbot
Copy link
Author

Comment author: @bob-the-hamster

Oops. this was fixed a couple weeks ago, but I forgot to mark it as such.

@ohrrpgce-bugbot ohrrpgce-bugbot added bug Yeah... that's broken os: windows Windows-specific crash Bugs causing a crash, freeze/hang, abort(), or FB fatal error rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16 labels Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Yeah... that's broken crash Bugs causing a crash, freeze/hang, abort(), or FB fatal error os: windows Windows-specific rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16
Projects
None yet
Development

No branches or pull requests

1 participant