Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out-of-control file growth when creating a new RPG file #138

Closed
ohrrpgce-bugbot opened this issue Feb 15, 2006 · 4 comments
Closed

out-of-control file growth when creating a new RPG file #138

ohrrpgce-bugbot opened this issue Feb 15, 2006 · 4 comments
Labels
bug Yeah... that's broken Custom General problems; use "editor UI" for editor issues rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16

Comments

@ohrrpgce-bugbot
Copy link

[bz#138]

Mike found a serious bug in the just-released serendipity. A file named
ohrrpgce.d00 grew out of control to a size over a gigabyte.

http://listserver.dreamhost.com/pipermail/ohrrpgce-motherhamster.org/2006-February/001526.html

From: @bob-the-hamster
Reported version: 20060215 Serendipity
Operating system: Windows 2000

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

Actually, it's grown much bigger. When I first discovered it, it was ~2.25
gigabytes. Just, the second time, when I was documenting it, I killed custom
before it got toooooooooooooooo big.

Also, it does not happen in the dos version, so I /highly/ suspect Simon's
lumping code. Will do research tommorow, when I'm not falling asleep at the
keyboard...

@ohrrpgce-bugbot
Copy link
Author

Comment author: Simon Bradley <neworiginal>

This is caused by:

(a) Incorrect file list. Findfiles() is appending entries instead of starting a
new file, which leaves unwanted entries, especially in a new RPG.

(b) Bad handling of non-existent files in lumpfiles().

I have committed a partial fix, which solves the latter, and fixes most serious
side of the problem, but the underlying issue of the incorrect file list is
still unsolved. Creating a new RPG and then saving it now creates a file double
the normal size, since everything is added (at least) twice, although it does
seem to work fine on subsequent access.

@ohrrpgce-bugbot
Copy link
Author

Comment author: @bob-the-hamster

from findfiles in allmodex.bas:

    if attrib = 0 then attrib = 255 xor 16
    dim ff%
    ff = FreeFile
    OPEN outfile$ FOR APPEND as #ff 'changed this to append, for efficiency

elsewhere
dim a$
a$ = DIR$(fmask$, attrib)
if a$ = "" then
close #ff
exit sub
end if
DO UNTIL a$ = ""
PRINT #ff,a$
a$ = DIR$("", attrib)
LOOP
CLOSE #ff

Changed and checked in.

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

I distinctly recall this being fixed, especially since Serendipity+ was
released. Marking as such.

@ohrrpgce-bugbot ohrrpgce-bugbot added Custom General problems; use "editor UI" for editor issues bug Yeah... that's broken rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16 labels Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Yeah... that's broken Custom General problems; use "editor UI" for editor issues rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16
Projects
None yet
Development

No branches or pull requests

1 participant