Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards in battle are awarded multiple times #142

Closed
ohrrpgce-bugbot opened this issue Feb 17, 2006 · 8 comments
Closed

Rewards in battle are awarded multiple times #142

ohrrpgce-bugbot opened this issue Feb 17, 2006 · 8 comments
Labels
battles Not specifically an attack bug/feature bug Yeah... that's broken rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16

Comments

@ohrrpgce-bugbot
Copy link

[bz#142]

..any battle formation will give off more experience than they're supposed
to;even the items dropped are increased significantly.

From: AdrianX <neo_adrian2001>
Reported version: 20060216 Serendipity+
Operating system: Windows XP
Severity: major

@ohrrpgce-bugbot
Copy link
Author

Comment author: @bob-the-hamster

Does this also happen in game-qb.exe, or is it only in the windows version?

@ohrrpgce-bugbot
Copy link
Author

Comment author: AdrianX <neo_adrian2001>

..i only have tested it in the windows version,but i think it also happens in
the qb version.

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

Ah ha. Look at the debugging log I generated by inserting some clevar debugging
statements in the routine that gives gold and experience (although it doesn't
show items, I think you'll get the idea of what's happening):

NME # 0 GOLD + 100 = 100
NME # 0 EXP. + 100 = 100
NME # 0 GOLD + 100 = 200
NME # 0 EXP. + 100 = 200
NME # 1 GOLD + 100 = 300
NME # 1 EXP. + 100 = 300
NME # 0 GOLD + 100 = 400
NME # 0 EXP. + 100 = 400
NME # 1 GOLD + 100 = 500
NME # 1 EXP. + 100 = 500
NME # 2 GOLD + 100 = 600
NME # 2 EXP. + 100 = 600
NME # 0 GOLD + 100 = 700
NME # 0 EXP. + 100 = 700
NME # 1 GOLD + 100 = 800
NME # 1 EXP. + 100 = 800
NME # 2 GOLD + 100 = 900
NME # 2 EXP. + 100 = 900
NME # 3 GOLD + 100 = 1000
NME # 3 EXP. + 100 = 1000

As you can see, first if gives plunder for enemy #⁠0. Then, it gives for #⁠0 and
#⁠1 (when you kill the next one). Then #⁠0, #⁠1 and #⁠2. Finally, it does #⁠0, #⁠1,
#⁠2, AND #⁠3. Thus, instead of getting 400 each of gold and experience, I get 1000
of each.(100 + 200 + 300 + 400 = 1000).

I will investigate why it won't let dead enemies stay that way...

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

All fixed. However, I uncovered another bug in the process :(

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

Oops, nevermind, I = moron.

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

*sigh* I mean, there is no second bug. This *is* fixed.

@ohrrpgce-bugbot
Copy link
Author

Comment author: AdrianX <neo_adrian2001>

..james had manually made a nightly build for me to test and the bug is fixed!
thanks! ^_^

@ohrrpgce-bugbot
Copy link
Author

Comment author: @pkmnfrk

*** Bug bz⁠#171 has been marked as a duplicate of this bug. ***

@ohrrpgce-bugbot ohrrpgce-bugbot added battles Not specifically an attack bug/feature bug Yeah... that's broken rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16 labels Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
battles Not specifically an attack bug/feature bug Yeah... that's broken rel: serendipity Present in serendipity 2006-02-15 / S+ 2006-02-16
Projects
None yet
Development

No branches or pull requests

1 participant